[llvm] r195472 - Revert "Convert linkonce* to weak* instead of strong."

[Rafael Espindola]

Author: rafael
Date: Fri Nov 22 11:09:34 2013
New Revision: 195472

URL: http://llvm.org/viewvc/llvm-project?rev=195472&view=rev
Log:
Revert "Convert linkonce* to weak* instead of strong."

This reverts commit r195470.
Debugging failure in some bots.

Modified:
    llvm/trunk/lib/Transforms/IPO/ExtractGV.cpp
    llvm/trunk/test/Other/extract-linkonce.ll

Modified: llvm/trunk/lib/Transforms/IPO/ExtractGV.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/ExtractGV.cpp?rev=195472&r1=195471&r2=195472&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/ExtractGV.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/ExtractGV.cpp Fri Nov 22 11:09:34 2013
@@ -21,38 +21,6 @@
 #include <algorithm>
 using namespace llvm;
 
-/// Make sure GV is visible from both modules. Delete is true if it is
-/// being deleted from this module.
-/// This also makes sure GV cannot be dropped so that references from
-/// the split module remain valid.
-static void makeVisible(GlobalValue &GV, bool Delete) {
-  bool Local = GV.hasLocalLinkage();
-  if (Local)
-    GV.setVisibility(GlobalValue::HiddenVisibility);
-
-  if (Local || Delete) {
-    GV.setLinkage(GlobalValue::ExternalLinkage);
-    return;
-  }
-
-  if (!GV.hasLinkOnceLinkage()) {
-    assert(!GV.isDiscardableIfUnused());
-    return;
-  }
-
-  // Map linkonce* to weak* so that llvm doesn't drop this GV.
-  switch(GV.getLinkage()) {
-  default:
-    llvm_unreachable("Unexpected linkage");
-  case GlobalValue::LinkOnceAnyLinkage:
-    GV.setLinkage(GlobalValue::WeakAnyLinkage);
-    return;
-  case GlobalValue::LinkOnceODRLinkage:
-    GV.setLinkage(GlobalValue::WeakODRLinkage);
-    return;
-  }
-}
-
 namespace {
   /// @brief A pass to extract specific functions and their dependencies.
   class GVExtractorPass : public ModulePass {
@@ -92,7 +60,12 @@ namespace {
             continue;
         }
 
-	makeVisible(*I, Delete);
+        bool Local = I->isDiscardableIfUnused();
+        if (Local)
+          I->setVisibility(GlobalValue::HiddenVisibility);
+
+        if (Local || Delete)
+          I->setLinkage(GlobalValue::ExternalLinkage);
 
         if (Delete)
           I->setInitializer(0);
@@ -107,7 +80,12 @@ namespace {
             continue;
         }
 
-	makeVisible(*I, Delete);
+        bool Local = I->isDiscardableIfUnused();
+        if (Local)
+          I->setVisibility(GlobalValue::HiddenVisibility);
+
+        if (Local || Delete)
+          I->setLinkage(GlobalValue::ExternalLinkage);
 
         if (Delete)
           I->deleteBody();
@@ -119,10 +97,12 @@ namespace {
         Module::alias_iterator CurI = I;
         ++I;
 
-	bool Delete = deleteStuff == (bool)Named.count(CurI);
-	makeVisible(*I, Delete);
+        if (CurI->isDiscardableIfUnused()) {
+          CurI->setVisibility(GlobalValue::HiddenVisibility);
+          CurI->setLinkage(GlobalValue::ExternalLinkage);
+        }
 
-        if (Delete) {
+        if (deleteStuff == (bool)Named.count(CurI)) {
           Type *Ty =  CurI->getType()->getElementType();
 
           CurI->removeFromParent();

Modified: llvm/trunk/test/Other/extract-linkonce.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/extract-linkonce.ll?rev=195472&r1=195471&r2=195472&view=diff
==============================================================================
--- llvm/trunk/test/Other/extract-linkonce.ll (original)
+++ llvm/trunk/test/Other/extract-linkonce.ll Fri Nov 22 11:09:34 2013
@@ -1,16 +1,15 @@
 ; RUN: llvm-extract -func foo -S < %s | FileCheck %s
 ; RUN: llvm-extract -delete -func foo -S < %s | FileCheck --check-prefix=DELETE %s
 
-; Test that linkonce definitions are mapped to weak so that they are not
-; dropped.
+; Test that we don't convert weak_odr to external definitions.
 
-; CHECK:      @bar = external global i32
-; CHECK:      define weak i32* @foo() {
+; CHECK:      @bar = external hidden global i32
+; CHECK:      define hidden i32* @foo() {
 ; CHECK-NEXT:  ret i32* @bar
 ; CHECK-NEXT: }
 
-; DELETE: @bar = weak global i32 42
-; DELETE: declare i32* @foo()
+; DELETE: @bar = hidden global i32 42
+; DELETE: declare hidden i32* @foo()
 
 @bar = linkonce global i32 42