Ping: Add a Scalarizer pass
Nadav Rotem
nrotem at apple.com
Fri Nov 22 08:50:13 PST 2013
Looks good to me.
On Nov 22, 2013, at 6:43 AM, Richard Sandiford <rsandifo at linux.vnet.ibm.com> wrote:
> Pekka Jääskeläinen <pekka.jaaskelainen at tut.fi> writes:
>> LGTM.
>>
>> IMHO this could be committed to the 3.4 branch as it's not part
>> of the default pass chain.
>
> Thanks Pekka. Nadav, since you had comments about the original version,
> is this OK with you too?
>
> Thanks,
> Richard
>
>> On 11/20/2013 01:06 PM, Richard Sandiford wrote:
>>> Ping for this update, which I think addresses all review comments so far.
>>>
>>> Thanks,
>>> Richard
>>>
>>>> Remove use of TargetTransformInfo. Do not add the pass to
>>>> PassManagerBuilder.
>>>>
>>>> We also talked about whether to use a reverse post-order traversal,
>>>> but I don't think it's worth it in the use cases I have. It could
>>>> easily be added later it we find a counterexample though.
>>>
>>> http://llvm-reviews.chandlerc.com/D2112
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>
More information about the llvm-commits
mailing list