[llvm] r190916 - Lift alignment restrictions for load/store folding on VINSERTF128/VEXTRACTF128. Fixes PR17268. [PATCH]

[Arnold Schwaighofer]

On Nov 21, 2013, at 12:18 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> ----- Original Message -----
>> From: "Arnold Schwaighofer" <aschwaighofer at apple.com>
>> To: "Hal Finkel" <hfinkel at anl.gov>
>> Cc: "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>, "Nadav Rotem" <nrotem at apple.com>
>> Sent: Thursday, November 21, 2013 11:54:05 AM
>> Subject: Re: [llvm] r190916 - Lift alignment restrictions for load/store folding on VINSERTF128/VEXTRACTF128. Fixes
>> PR17268. [PATCH]
>> 
>> Oh, I see. We used to use the cl::opt flag for communicating settings
>> from the front-end.
>> 
>> Now, we want it to override settings from the front end (be it opt or
>> clang):
>> 
>> So we want something like:
> 
> Yes. Although we may want to check for getNumOccurrences() > 0 instead of getPosition() just to be clearer.

Yes. Absolutely.