[llvm] r195358 - [ARM] add basic Cortex-A7 support to LLVM backend

[Artyom Skrobov]

Kristof, thank you for pointing this out -- these checks were intended to go
in as clang/test/CodeGen/a7.c, but this file didn't get committed due to my
error.

Now committed as r195365, with the testcase renamed to
CodeGen/ARM/build-attributes.ll which seems to reflect its purpose better.


-----Original Message-----
From: Kristof Beyls 
Sent: 21 November 2013 15:53
To: Artyom Skrobov; llvm-commits at cs.uiuc.edu
Subject: RE: [llvm] r195358 - [ARM] add basic Cortex-A7 support to LLVM
backend

Hi Artyom,

I think you should also add checks to verify the correct build attributes
are emitted when targeting Cortex-A7. See test
CodeGen/ARM/2010-09-29-mc-asm-header-test.ll

Thanks,

Kristof


> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Artyom Skrobov
> Sent: 21 November 2013 14:03
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm] r195358 - [ARM] add basic Cortex-A7 support to LLVM
backend
> 
> Author: askrobov
> Date: Thu Nov 21 08:03:21 2013
> New Revision: 195358
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=195358&view=rev
> Log:
> [ARM] add basic Cortex-A7 support to LLVM backend
> 
> Modified:
>     llvm/trunk/lib/Target/ARM/ARM.td
>     llvm/trunk/lib/Target/ARM/ARMSubtarget.h
> 
> Modified: llvm/trunk/lib/Target/ARM/ARM.td
> URL: http://llvm.org/viewvc/llvm-
>
project/llvm/trunk/lib/Target/ARM/ARM.td?rev=195358&r1=195357&r2=195358&view
=d
> iff
>
============================================================================
==
> --- llvm/trunk/lib/Target/ARM/ARM.td (original)
> +++ llvm/trunk/lib/Target/ARM/ARM.td Thu Nov 21 08:03:21 2013
> @@ -180,6 +180,13 @@ def ProcA5      : SubtargetFeature<"a5",
>                                     [FeatureSlowFPBrcc,
FeatureHasSlowFPVMLx,
>                                      FeatureVMLxForwarding, FeatureT2XtPk,
>                                      FeatureTrustZone]>;
> +def ProcA7      : SubtargetFeature<"a7", "ARMProcFamily", "CortexA7",
> +                                   "Cortex-A7 ARM processors",
> +                                   [FeatureSlowFPBrcc,
FeatureHasSlowFPVMLx,
> +                                    FeatureVMLxForwarding, FeatureT2XtPk,
> +                                    FeatureVFP4, FeatureMP,
> +                                    FeatureHWDiv, FeatureHWDivARM,
> +                                    FeatureTrustZone,
> FeatureVirtualization]>;
>  def ProcA8      : SubtargetFeature<"a8", "ARMProcFamily", "CortexA8",
>                                     "Cortex-A8 ARM processors",
>                                     [FeatureSlowFPBrcc,
FeatureHasSlowFPVMLx,
> @@ -296,6 +303,10 @@ def : ProcessorModel<"cortex-a5",   Cort
>                                      [ProcA5, HasV7Ops, FeatureNEON,
> FeatureDB,
>                                       FeatureVFP4, FeatureDSPThumb2,
>                                       FeatureHasRAS, FeatureAClass]>;
> +def : ProcessorModel<"cortex-a7",   CortexA8Model,
> +                                    [ProcA7, HasV7Ops, FeatureNEON,
> FeatureDB,
> +                                     FeatureDSPThumb2, FeatureHasRAS,
> +                                     FeatureAClass]>;
>  def : ProcessorModel<"cortex-a8",   CortexA8Model,
>                                      [ProcA8, HasV7Ops, FeatureNEON,
> FeatureDB,
>                                       FeatureDSPThumb2, FeatureHasRAS,
> 
> Modified: llvm/trunk/lib/Target/ARM/ARMSubtarget.h
> URL: http://llvm.org/viewvc/llvm-
>
project/llvm/trunk/lib/Target/ARM/ARMSubtarget.h?rev=195358&r1=195357&r2=195
35
> 8&view=diff
>
============================================================================
==
> --- llvm/trunk/lib/Target/ARM/ARMSubtarget.h (original)
> +++ llvm/trunk/lib/Target/ARM/ARMSubtarget.h Thu Nov 21 08:03:21 2013
> @@ -31,7 +31,8 @@ class TargetOptions;
>  class ARMSubtarget : public ARMGenSubtargetInfo {
>  protected:
>    enum ARMProcFamilyEnum {
> -    Others, CortexA5, CortexA8, CortexA9, CortexA15, CortexR5, Swift,
> CortexA53, CortexA57
> +    Others, CortexA5, CortexA7, CortexA8, CortexA9, CortexA15, CortexR5,
> +    Swift, CortexA53, CortexA57
>    };
>    enum ARMProcClassEnum {
>      None, AClass, RClass, MClass
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits