[compiler-rt] r195351 - tsan: deflake tests

Dmitry Vyukov dvyukov at google.com
Thu Nov 21 04:23:17 PST 2013


Author: dvyukov
Date: Thu Nov 21 06:23:17 2013
New Revision: 195351

URL: http://llvm.org/viewvc/llvm-project?rev=195351&view=rev
Log:
tsan: deflake tests

the tests produce episodic flakes
the hypothesis is that it's due to our "racy" race detection algorithm
sleeps should remove the flakes


Modified:
    compiler-rt/trunk/lib/tsan/lit_tests/tls_race.cc
    compiler-rt/trunk/lib/tsan/lit_tests/tls_race2.cc

Modified: compiler-rt/trunk/lib/tsan/lit_tests/tls_race.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/lit_tests/tls_race.cc?rev=195351&r1=195350&r2=195351&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/lit_tests/tls_race.cc (original)
+++ compiler-rt/trunk/lib/tsan/lit_tests/tls_race.cc Thu Nov 21 06:23:17 2013
@@ -1,8 +1,10 @@
 // RUN: %clangxx_tsan -O1 %s -o %t && not %t 2>&1 | FileCheck %s
 #include <pthread.h>
 #include <stddef.h>
+#include <unistd.h>
 
 void *Thread(void *a) {
+  sleep(1);
   *(int*)a = 43;
   return 0;
 }

Modified: compiler-rt/trunk/lib/tsan/lit_tests/tls_race2.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/lit_tests/tls_race2.cc?rev=195351&r1=195350&r2=195351&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/lit_tests/tls_race2.cc (original)
+++ compiler-rt/trunk/lib/tsan/lit_tests/tls_race2.cc Thu Nov 21 06:23:17 2013
@@ -4,6 +4,7 @@
 #include <unistd.h>
 
 void *Thread2(void *a) {
+  sleep(1);
   *(int*)a = 43;
   return 0;
 }





More information about the llvm-commits mailing list