[PATCH] Generalize debug info / EH emission in AsmPrinter

Timur Iskhodzhanov timurrrr at google.com
Wed Nov 20 03:56:17 PST 2013



================
Comment at: lib/CodeGen/AsmPrinter/DebugInfoEmitter.h:25
@@ +24,3 @@
+
+class DebugInfoEmitter {
+public:
----------------
Reid Kleckner wrote:
> Is this the right name to abstract over codeview line tables, various EH impls, and general debug info?  IMO it deserves a doc comment to explain what kind of thing might implement one of these.
> Is this the right name to abstract over codeview line tables, various EH impls, and general debug info?

Agree, good point.
Initially I wanted to use this interface for DI only, but it turned out I can use it for EH as well... but forgotten to update the name.

I couldn't find a good name though. AsmPrinterObserver? DebugEHInfoEmitter? Any other ideas?

> IMO it deserves a doc comment to explain what kind of thing might implement one of these.

Agree, done.


http://llvm-reviews.chandlerc.com/D2222



More information about the llvm-commits mailing list