[llvm] r195064 - [weak vtables] Remove a bunch of weak vtables

[Andrew Trick]

On Nov 18, 2013, at 7:16 PM, Juergen Ributzka <juergen at apple.com> wrote:

> Hi Chandler,
> 
> I moved the class definitions in the implementation files into anonymous namespaces as you suggested. Looks much better this way :-) I committed the fix in r195092.

Much better. Thanks Chandler.
-Andy

> 
> Thanks
> 
> Cheers,
> Juergen
> 
> 
> On Nov 18, 2013, at 6:05 PM, Juergen Ributzka <juergen at apple.com> wrote:
> 
>> Good point! I will fix that right away in a followup commit.
>> 
>> On Nov 18, 2013, at 5:53 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> 
>>> On Mon, Nov 18, 2013 at 4:57 PM, Juergen Ributzka <juergen at apple.com> wrote:
>>> [weak vtables] Remove a bunch of weak vtables
>>> 
>>> This patch removes most of the trivial cases of weak vtables by pinning them to
>>> a single object file. The memory leaks in this version have been fixed. Thanks
>>> Alexey for pointing them out.
>>> 
>>> I think this patch is wrong in a number of cases. Specifically when there is a class in a .cpp file, there is no need to have an out-of-line virtual method definition. Instead, the class should be placed in an anonymous namespace.
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131119/8b08237a/attachment.html>