[llvm] r194957 - DebugLoc defines LineCol as 32 bit in comment but unsigned in code.

Chris Lattner clattner at apple.com
Tue Nov 19 10:14:46 PST 2013


On Nov 17, 2013, at 1:47 AM, Yaron Keren <yaron.keren at gmail.com> wrote:

> Author: yrnkrn
> Date: Sun Nov 17 03:47:39 2013
> New Revision: 194957
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=194957&view=rev
> Log:
> DebugLoc defines LineCol as 32 bit in comment but unsigned in code.
> This patch modifies LineCol to be a uint32_t.
> 
> See http://llvm.org/bugs/show_bug.cgi?id=17957

Are you really trying to build LLVM on a system where “unsigned” is 64-bits?  You’re going to run into pervasive problems, and it isn’t clear to me that fixing them piecemeal is going to work.  LLVM and Clang generally assume that int and unsigned are both 32-bits.

-Chris



More information about the llvm-commits mailing list