[PATCH] Write references to Native format in NativeReferenceIvarsV2.

Rui Ueyama ruiu at google.com
Mon Nov 18 21:37:49 PST 2013


So, I'd like to get some input on how to test this patch.

The new file format is used basically only when there are more than 2^16
relocations in a file. It's easy to create a file containing lots of
relocations using .rept macro in assembly, but such a file in an object
file format could be large (~2MB). I don't think we want to check in such
large binary file to the repository.

One workaround would be to check in only the assembly file, and run as when
test is run. Does that make sense? Is there a best practice for this?


On Mon, Nov 18, 2013 at 9:23 PM, Rui Ueyama <ruiu at google.com> wrote:

>   Updated as per Nick's comments.
>
>   - Resurrect V1 format
>   - Use V2 format only when the resulting file cannot be represented in V1
>
> Hi kledzik, Bigcheese, shankarke,
>
> http://llvm-reviews.chandlerc.com/D2217
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D2217?vs=5641&id=5647#toc
>
> Files:
>   lib/ReaderWriter/Native/NativeFileFormat.h
>   lib/ReaderWriter/Native/ReaderNative.cpp
>   lib/ReaderWriter/Native/WriterNative.cpp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131118/a8247a48/attachment.html>


More information about the llvm-commits mailing list