[PATCH] llvm-cov: Updated file checksum to be timestamp.

[Nick Lewycky]

On 18 November 2013 20:16, Yuchen Wu <yuchenericwu at hotmail.com> wrote:

> Hi all,
>
> I've updated the patch so that the file checksum is the crc32 of arc
> destinations. Please take a look!
>
> Function and line checksums coming soon.
>

Thanks!

+    void setCfgChecksum(uint32_t Checksum) {
+      CfgChecksum = Checksum;
+    }

This function appears to be unused?

+    FileChecksum = zlib::crc32(EdgeDestinations);

Oof. So, if we don't link in zlib when building llvm, this is undefined
behaviour on the spot (it isn't even guaranteed to terminate, it uses
llvm_unreachable).

There's no need to use a crc32 here, just use whatever is in ADT/Hashing.h.

LGTM with above fixed.

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131118/6d79ab2a/attachment.html>