[llvm] r195064 - [weak vtables] Remove a bunch of weak vtables

[Chandler Carruth]

On Mon, Nov 18, 2013 at 4:57 PM, Juergen Ributzka <juergen at apple.com> wrote:

> [weak vtables] Remove a bunch of weak vtables
>
> This patch removes most of the trivial cases of weak vtables by pinning
> them to
> a single object file. The memory leaks in this version have been fixed.
> Thanks
> Alexey for pointing them out.
>

I think this patch is wrong in a number of cases. Specifically when there
is a class in a .cpp file, there is no need to have an out-of-line virtual
method definition. Instead, the class should be placed in an anonymous
namespace.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131118/8deb3ff3/attachment.html>