[llvm] r194601 - Use StringRef instead of std::string

[Jakub Staszak]

Right, thanks a lot. 

- Kuba

On Nov 18, 2013, at 8:16 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Kuba,
> 
> It was bad, ... BB would be invalidated after BB->eraseFromParent().
> Tweaked in r194970.
> 
> It caused crash in stage 3 (stage2-clang) for me.
> 
> 2013/11/14 Jakub Staszak <kubastaszak at gmail.com>:
>> Author: kuba
>> Date: Wed Nov 13 14:09:11 2013
>> New Revision: 194601
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=194601&view=rev
>> Log:
>> Use StringRef instead of std::string
>> 
>> Modified:
>>    llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
>> 
>> Modified: llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp?rev=194601&r1=194600&r2=194601&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp (original)
>> +++ llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp Wed Nov 13 14:09:11 2013
>> @@ -90,7 +90,7 @@ static BasicBlock *FoldBlockIntoPredeces
>>   // Move all definitions in the successor to the predecessor...
>>   OnlyPred->getInstList().splice(OnlyPred->end(), BB->getInstList());
>> 
>> -  std::string OldName = BB->getName();
>> +  StringRef OldName = BB->getName();
>> 
>>   // Erase basic block from the function...
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits