Re: [PATCH] Implement ‘optnone’ attribute semantics

[Bill Wendling]

On Nov 13, 2013, at 4:09 PM, Robinson, Paul <Paul_Robinson at playstation.sony.com> wrote:

> I am energized by positive discussions of the 'optnone' attribute
> during the dev meeting last week, so here we go.
> 
> Some time ago Andrea Di Biagio committed a patch to define an 'optnone'
> attribute in the LLVM IR; he has since passed the torch to me on this
> one, so I'm attaching 3 patches to implement the semantics we want.
> 
> While the patches all address semantics of 'optnone' I should point
> out that (I'm pretty sure) they are independent of each other and
> don't have to be reviewed sequentially, or anything like that.
> 
> Patch #1 tweaks the description of 'optnone' to require 'noinline',
> and updates the verifier and two existing tests accordingly.  The
> requirement means an 'optnone' function won't be inlined into any
> caller.  The patch also makes the inliner not inline any calls made by
> an 'optnone' function, with one exception: an 'always_inline' function
> will be inlined into an 'optnone' function.
> 
Hi Paul,

Patch #1 LGTM!

-bw