[PATCH] Loop Rerolling Pass
Nadav Rotem
nrotem at apple.com
Fri Nov 15 17:41:50 PST 2013
I am in favor of committing this and working on it on ToT.
> On Nov 15, 2013, at 16:55, Hal Finkel <hfinkel at anl.gov> wrote:
>
> Ping.
>
> Andy, you had said that you did not object to me committing this and working on it in-tree. Can I take that as permission? Really, I don't want to commit a bunch of unreadable code, but I think it is better at this point, and I'd appreciate it if you (or anyone else), would take a quick look and provide some feedback on whether it looks reviewable.
>
> Thanks again,
> Hal
>
> ----- Original Message -----
>> Ping.
>>
>> -Hal
>>
>> ----- Original Message -----
>>> This should address the remainder of the initial review comments.
>>> I've factored out the reduction tracking into its own class, and
>>> made a number of other improvements. I've added more function
>>> documentation, including documentation on the overall algorithm.
>>> Hopefully, this is more reviewable now.
>>>
>>> To be clear, the pass-manager change is only there to ease
>>> testing,
>>> and would not be committed in this way.
>>>
>>> Thanks again!
>>>
>>> Hi nadav, rengolin, atrick,
>>>
>>> http://llvm-reviews.chandlerc.com/D1940
>>>
>>> CHANGE SINCE LAST DIFF
>>> http://llvm-reviews.chandlerc.com/D1940?vs=5209&id=5245#toc
>>>
>>> Files:
>>> include/llvm-c/Transforms/Scalar.h
>>> include/llvm/InitializePasses.h
>>> include/llvm/LinkAllPasses.h
>>> include/llvm/Transforms/Scalar.h
>>> lib/Transforms/IPO/PassManagerBuilder.cpp
>>> lib/Transforms/Scalar/CMakeLists.txt
>>> lib/Transforms/Scalar/LoopRerollPass.cpp
>>> lib/Transforms/Scalar/Scalar.cpp
>>> test/Transforms/LoopReroll/basic.ll
>>> test/Transforms/LoopReroll/reduction.ll
>>
>> --
>> Hal Finkel
>> Assistant Computational Scientist
>> Leadership Computing Facility
>> Argonne National Laboratory
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list