[PATCH] Allow multiple coff sections with the name but different comdat symbols

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Nov 15 14:52:48 PST 2013


Hi rnk,

This is the first step to fix pr17918.

The patch basically ports the ELF logic to COFF. It also needs to extend the .section directive a bit, inspired by what the ELF one looks like. The problem with using linkonce is that given

.section foo
.linkonce....

.section foo
.linkonce

we would already have switched sections when getting to .linkonce. The cleanest solution seems to be to add the comdat information in the .section itself.


http://llvm-reviews.chandlerc.com/D2193

Files:
  include/llvm/MC/MCContext.h
  include/llvm/MC/MCSectionCOFF.h
  lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  lib/MC/MCContext.cpp
  lib/MC/MCParser/COFFAsmParser.cpp
  lib/MC/WinCOFFStreamer.cpp
  test/MC/COFF/section-comdat.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2193.1.patch
Type: text/x-patch
Size: 18724 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131115/e3913c68/attachment.bin>


More information about the llvm-commits mailing list