[PATCH] Select new undefined atom rather than old one if other conditions are the same.

[Rui Ueyama]

On Thu, Nov 14, 2013 at 6:41 PM, kledzik at apple.com <kledzik at apple.com>wrote:

>
>
> ================
> Comment at: lib/Core/SymbolTable.cpp:192-194
> @@ +191,5 @@
> +    const UndefinedAtom *newFallback = newUndef->fallback();
> +    bool hasDifferentFallback =
> +        (existingFallback && newFallback &&
> +         existingFallback->name() != newFallback->name());
> +    if (hasDifferentFallback) {
> ----------------
> hasDifferentFallback should also be true if one has a fallback and the
> other does not.
>

If the existing atom does not have a fallback and new one has, it's normal
-- no need to warn that. So the condition would be a bit complicated that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131114/52a4e879/attachment.html>