[PATCH] Recognize 0x0000 as a COFF file magic.

[Rafael Espíndola]

Can you add a testcase?

On 13 November 2013 01:45, Rui Ueyama <ruiu at google.com> wrote:
> Hi Bigcheese,
>
> Some machine-type-neutral object files containing only undefined symbols
> actually do exist in the Windows standard library. Need to recognize them
> as COFF files.
>
> http://llvm-reviews.chandlerc.com/D2164
>
> Files:
>   lib/Support/Path.cpp
>
> Index: lib/Support/Path.cpp
> ===================================================================
> --- lib/Support/Path.cpp
> +++ lib/Support/Path.cpp
> @@ -853,6 +853,9 @@
>        if (Magic.size() >= sizeof(Expected) &&
>            memcmp(Magic.data(), Expected, sizeof(Expected)) == 0)
>          return file_magic::windows_resource;
> +      // 0x0000 = COFF unknown machine type
> +      if (Magic[1] == 0)
> +        return file_magic::coff_object;
>        break;
>      }
>      case 0xDE:  // 0x0B17C0DE = BC wraper
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>