[PATCH] FileCheck: fix a bug with multiple --check-prefix options.

Daniel Sanders daniel.sanders at imgtec.com
Wed Nov 13 03:38:32 PST 2013


  Well spotted. LGTM.

  One minor nit is that I think that the 'FOO: foo' line should probably be 'FOO: fo{{o}}' or similar. It makes no difference to this test though. My thinking is that that it's not obvious to new readers that FileCheck that it will happily match portions of its own directives. The presence of the curly braces should at least get these readers to question why they're there.
  Similarly for the 'CHECK:' line even though the CHECK line won't be present in the output of the first FileCheck command..

http://llvm-reviews.chandlerc.com/D2166

BRANCH
  svn

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list