[patch] Remove AllowQuotesInName and friends from MCAsmInfo.

Chris Lattner clattner at apple.com
Tue Nov 12 21:19:34 PST 2013


LGTM!

On Nov 12, 2013, at 3:45 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

> Hi Chris,
> 
> Chatting on the dev meeting about the mangler we decide to try to
> simplify it to use target data. That way it can keep adding the _
> prefix and the fastcall/thiscall suffixes without having to link all
> targets into llvm-ar (for example).
> 
> This is the first patch is that direction. Accepting quotes is a
> property of an assembler, not of an object file. For example, ELF can
> support any names for sections and symbols, but the gnu assembler only
> accepts quotes in some contexts and llvm-mc in a few more.
> 
> LLVM should not produce different symbols based on a guess about which
> assembler will be reading the code it is printing.
> 
> Cheers,
> Rafael
> <t.patch>





More information about the llvm-commits mailing list