[PATCH][AArch32]Allow unrestricted IT blocks

[Weiming Zhao]

Hi Renato,

 

Thanks for catching the typo and unneeded changes (did by clang formatter
:D)

 

I'm attaching the modified patches.

 

Thanks,

Weiming

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: Tuesday, November 12, 2013 1:25 AM
To: Zhao
Cc: LLVM Commits
Subject: Re: [PATCH][AArch32]Allow unrestricted IT blocks

 

Hi Weiming,

 

Looks good. A few comments:

 

+              clEnumValN(NoRestrictedIT, "arm-no-restrict-it",

+                         "Allow IT blocks of ARMv7"),

 

typo "on ARMv7".

 

+static cl::opt<bool> DisableUseMOVT("arm-disable-use-movt",
cl::init(false),

+                                    cl::Hidden, cl::ZeroOrMore);

 

I wouldn't change this. Try to make it as it was, so that the change log
doesn't blame you for anything. ;)

 

thanks,

--renato

 

 

 

On 12 November 2013 01:38, Weiming Zhao <weimingz at codeaurora.org> wrote:

Hi,

 

AArch32 allows Thumbv7 IT blocks to be executed for backward compatibility.

GCC has a  "-mno-restrict-it" flag.
http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00164.html

Attached are the patches for llvm and clang that provides similar
functionality.

 

Please help to review them.

 

Thanks,

Weiming

 

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/5d6e1890/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Enable-generating-legacy-IT-block-for-AArch32.patch
Type: application/octet-stream
Size: 11922 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/5d6e1890/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adds-backend-options-mrestrict-it-and-mno-restrict-i.patch
Type: application/octet-stream
Size: 3282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/5d6e1890/attachment-0001.obj>