[llvm] r194453 - llvm-cov: Added call to update run/program counts.

Yuchen Wu yuchenericwu at hotmail.com
Tue Nov 12 10:54:42 PST 2013


Sorry about that, I was about to check-in the compiler-rt change that includes llvm_gcda_summary_info, but then a previous commit broke the buildbot so I got sidetracked. I didn't see any further build failures, so I thought it was okay leaving this commit in.

I've since committed the compiler-rt changes in r194499. Please let me know if anything else is broken.

________________________________
> From: nlewycky at google.com 
> Date: Tue, 12 Nov 2013 01:21:20 -0800 
> Subject: Re: [llvm] r194453 - llvm-cov: Added call to update 
> run/program counts. 
> To: yuchenericwu at hotmail.com 
> CC: llvm-commits at cs.uiuc.edu 
> 
> On 11 November 2013 20:59, Yuchen Wu 
> <yuchenericwu at hotmail.com<mailto:yuchenericwu at hotmail.com>> wrote: 
> Author: ywu 
> Date: Mon Nov 11 22:59:08 2013 
> New Revision: 194453 
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=194453&view=rev 
> Log: 
> llvm-cov: Added call to update run/program counts. 
> 
> Also updated test files that were generated from this change. 
> 
> Please revert. There is no "llvm_gcda_summary_info" in the profile 
> runtime yet, so coverage information is broken at trunk. 
> 
> Nick 
> 
> 
> Modified: 
> llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp 
> llvm/trunk/test/tools/llvm-cov/Inputs/test.gcda 
> llvm/trunk/test/tools/llvm-cov/Inputs/test.gcno 
> 
> Modified: llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp 
> URL: 
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp?rev=194453&r1=194452&r2=194453&view=diff 
> ============================================================================== 
> --- llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp (original) 
> +++ llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp Mon Nov 
> 11 22:59:08 2013 
> @@ -102,6 +102,7 @@ namespace { 
> Constant *getIncrementIndirectCounterFunc(); 
> Constant *getEmitFunctionFunc(); 
> Constant *getEmitArcsFunc(); 
> + Constant *getSummaryInfoFunc(); 
> Constant *getDeleteWriteoutFunctionListFunc(); 
> Constant *getDeleteFlushFunctionListFunc(); 
> Constant *getEndFileFunc(); 
> @@ -700,6 +701,11 @@ Constant *GCOVProfiler::getEmitArcsFunc( 
> return M->getOrInsertFunction("llvm_gcda_emit_arcs", FTy); 
> } 
> 
> +Constant *GCOVProfiler::getSummaryInfoFunc() { 
> + FunctionType *FTy = FunctionType::get(Type::getVoidTy(*Ctx), false); 
> + return M->getOrInsertFunction("llvm_gcda_summary_info", FTy); 
> +} 
> + 
> Constant *GCOVProfiler::getDeleteWriteoutFunctionListFunc() { 
> FunctionType *FTy = FunctionType::get(Type::getVoidTy(*Ctx), false); 
> return M->getOrInsertFunction("llvm_delete_writeout_function_list", FTy); 
> @@ -746,6 +752,7 @@ Function *GCOVProfiler::insertCounterWri 
> Constant *StartFile = getStartFileFunc(); 
> Constant *EmitFunction = getEmitFunctionFunc(); 
> Constant *EmitArcs = getEmitArcsFunc(); 
> + Constant *SummaryInfo = getSummaryInfoFunc(); 
> Constant *EndFile = getEndFileFunc(); 
> 
> NamedMDNode *CU_Nodes = 
> M->getNamedMetadata("llvm.dbg.cu<http://llvm.dbg.cu>"); 
> @@ -772,6 +779,7 @@ Function *GCOVProfiler::insertCounterWri 
> Builder.getInt32(Arcs), 
> Builder.CreateConstGEP2_64(GV, 0, 0)); 
> } 
> + Builder.CreateCall(SummaryInfo); 
> Builder.CreateCall(EndFile); 
> } 
> } 
> 
> Modified: llvm/trunk/test/tools/llvm-cov/Inputs/test.gcda 
> URL: 
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/Inputs/test.gcda?rev=194453&r1=194452&r2=194453&view=diff 
> ============================================================================== 
> Binary files llvm/trunk/test/tools/llvm-cov/Inputs/test.gcda (original) 
> and llvm/trunk/test/tools/llvm-cov/Inputs/test.gcda Mon Nov 11 22:59:08 
> 2013 differ 
> 
> Modified: llvm/trunk/test/tools/llvm-cov/Inputs/test.gcno 
> URL: 
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/Inputs/test.gcno?rev=194453&r1=194452&r2=194453&view=diff 
> ============================================================================== 
> Binary files llvm/trunk/test/tools/llvm-cov/Inputs/test.gcno (original) 
> and llvm/trunk/test/tools/llvm-cov/Inputs/test.gcno Mon Nov 11 22:59:08 
> 2013 differ 
> 
> 
> _______________________________________________ 
> llvm-commits mailing list 
> llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu> 
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits 
> 		 	   		  



More information about the llvm-commits mailing list