[PATCH] [ASan] Do not rely on malloc context in allocator reports

Yury Gribov tetra2005 at gmail.com
Tue Nov 12 09:39:51 PST 2013


  I'm fine with submitting this.


================
Comment at: lib/asan/lit_tests/TestCases/Linux/malloc_delete_mismatch.cc:8
@@ -7,2 +7,3 @@
 // No error here.
-// RUN: ASAN_OPTIONS=alloc_dealloc_mismatch=0 %t
+// RUN: ASAN_OPTIONS=alloc_dealloc_mismatch=0 %t --check-prefix=CHECK-CTX
+
----------------
Alexey Samsonov wrote:
> no need in --check-prefix here, as FileCheck is not invoked.
Right, silly me.

================
Comment at: lib/sanitizer_common/sanitizer_stacktrace.h:49
@@ -47,3 +48,3 @@
       trace[i] = src[i];
   }
 
----------------
Alexey Samsonov wrote:
> top_frame_bp = 0;
Sorry, not quite clear. You want to initialize top_frame_bp to 0? But we don't have a ctor for StackTrace...


http://llvm-reviews.chandlerc.com/D2136



More information about the llvm-commits mailing list