[llvm] r194459 - Change data structure to memorize computed result in ScalarEvolution

[Wan, Xiaofei]

Sorry, we discussed it privately to get quick response, see emails attached.

Thanks
Wan Xiaofei
From: Chandler Carruth [mailto:chandlerc at google.com]
Sent: Tuesday, November 12, 2013 5:56 PM
To: Wan, Xiaofei
Cc: Commit Messages and Patches for LLVM
Subject: Re: [llvm] r194459 - Change data structure to memorize computed result in ScalarEvolution


On Tue, Nov 12, 2013 at 1:40 AM, Wan Xiaofei <xiaofei.wan at intel.com<mailto:xiaofei.wan at intel.com>> wrote:
Author: xiaofei.wan
Date: Tue Nov 12 03:40:41 2013
New Revision: 194459

URL: http://llvm.org/viewvc/llvm-project?rev=194459&view=rev
Log:
Change data structure to memorize computed result in ScalarEvolution

Replace std::map with SmallVector to memorize the cached result since SCEV usually belongs to little Loop/BB
Linear scan on SmallVector is faster than std::map.

Code reviewer : Andrew Trick.

Please revert this.

Andy never reviewed this on the mailing list. Hal gave one comment, which you replied to, and no updates to the code review thread have occurred. There was no code review or LGTM. =/ I really like the idea of this patch, but you can't just bypass the code review process like this!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/4206a693/attachment.html>
-------------- next part --------------
An embedded message was scrubbed...
From: Andrew Trick <atrick at apple.com>
Subject: Re: [PATCH] [ScalarEvolution] Change data structure to memorize computed	result
Date: Tue, 12 Nov 2013 00:10:24 +0000
Size: 17565
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131112/4206a693/attachment.mht>