[compiler-rt] r194369 - [asan] Bypass pthread_attr_getdetachstate interceptor in compiler_rt code.

[Evgeniy Stepanov]

None. I don't have an explanation how the old code could have caused
the issues we are seeing. Probably unrelated.

This simply looks like the right thing to do, and is a tiny bit faster.


On Mon, Nov 11, 2013 at 1:42 PM, Chandler Carruth <chandlerc at google.com> wrote:
> Test case?
>
>
> On Mon, Nov 11, 2013 at 12:56 AM, Evgeniy Stepanov
> <eugeni.stepanov at gmail.com> wrote:
>>
>> Author: eugenis
>> Date: Mon Nov 11 02:56:49 2013
>> New Revision: 194369
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=194369&view=rev
>> Log:
>> [asan] Bypass pthread_attr_getdetachstate interceptor in compiler_rt code.
>>
>> Modified:
>>     compiler-rt/trunk/lib/asan/asan_interceptors.cc
>>
>> Modified: compiler-rt/trunk/lib/asan/asan_interceptors.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_interceptors.cc?rev=194369&r1=194368&r2=194369&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/asan/asan_interceptors.cc (original)
>> +++ compiler-rt/trunk/lib/asan/asan_interceptors.cc Mon Nov 11 02:56:49
>> 2013
>> @@ -166,7 +166,7 @@ INTERCEPTOR(int, pthread_create, void *t
>>    GET_STACK_TRACE_THREAD;
>>    int detached = 0;
>>    if (attr != 0)
>> -    pthread_attr_getdetachstate(attr, &detached);
>> +    REAL(pthread_attr_getdetachstate)(attr, &detached);
>>
>>    u32 current_tid = GetCurrentTidOrInvalid();
>>    AsanThread *t = AsanThread::Create(start_routine, arg);
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>