[PATCH] Consider error-reporting calls cold in BPI

Chandler Carruth chandlerc at google.com
Sat Nov 9 16:32:42 PST 2013


On Sat, Nov 9, 2013 at 5:44 AM, Hal Finkel <hfinkel at anl.gov> wrote:

> Okay, I've attached a patch that adds this into SimplifyLibCalls. In this
> incarnation, I've added the functionality at the top-level of
> SimplifyLibCalls itself (which makes it different from all of the other
> simplifications). My rationale for this is that adding the cold hint should
> not depend on the builtin status of the functions. I'm not sure how much I
> like this. Thoughts?


I think it should depend on the builtin status of the functions. If we're
in a freestanding environment, there is no reason to believe that the
meanings for the various file descriptors continue to hold.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131109/f0f61b17/attachment.html>


More information about the llvm-commits mailing list