[PATCH] R600/SI: Change formatting of printed registers.

Vincent Lejeune vljn at ovi.com
Sat Nov 9 05:18:02 PST 2013


  Some format comments, otherwise the patch is :
  reviewed-by:Vincent Lejeune<vljn at ovi.com>


================
Comment at: lib/Target/R600/InstPrinter/AMDGPUInstPrinter.cpp:31
@@ +30,3 @@
+    return;
+
+  case AMDGPU::SCC:
----------------
I think the extra empty lines in switch statement can be removed.

================
Comment at: lib/Target/R600/InstPrinter/AMDGPUInstPrinter.cpp:72
@@ +71,3 @@
+    O << 'v';
+  } else if (SubRegName.front() == 'S') {
+    O << 's';
----------------
'{" aren't required when there the body of the statement is a single line long


http://llvm-reviews.chandlerc.com/D2130



More information about the llvm-commits mailing list