[PATCH] Consider error-reporting calls cold in BPI

[Chandler Carruth]

On Fri, Nov 8, 2013 at 12:33 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> > Okay, thanks! (Maybe this leaves me with InstCombine?) Does anything
> > else use, or is expected to use, the cold attribute directly in
> > addition to BPI? If not, maybe leaving this in BPI is just as good
> > as anything else.
>
> Chandler, please express an opinion. Would you want this in InstCombine?
> Thanks!


Sorry, missed this email.

I agree with your analysis that FunctionAttrs is the wrong place. Sorry for
that.

I think I would put this in SimplifyLibCalls much as Meador Inge has said
now. That's where we make assumptions about library calls having special
meaning, and this makes a lot of sense to me as being part of that. And
this would in turn run inside of InstCombine.

-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131108/08e6c417/attachment.html>