[lld] r194290 - [mach-o] fix uninitialized variable

[Nick Kledzik]

On Nov 8, 2013, at 3:26 PM, Sean Silva <silvas at purdue.edu> wrote:
> Would this have been caught by ASan/MSan? If so, then maybe we should look into setting up a bot.

One of the build bots was failing, and I finally tracked it down to this.   But having MSan point right at the problem would have been even better.

I thought Shankar was looking into adding Asan/Msan build bots but the bots were already running a full load?

-Nick


> 
> On Fri, Nov 8, 2013 at 6:00 PM, Nick Kledzik <kledzik at apple.com> wrote:
> Author: kledzik
> Date: Fri Nov  8 17:00:26 2013
> New Revision: 194290
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=194290&view=rev
> Log:
> [mach-o] fix uninitialized variable
> 
> Modified:
>     lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp
> 
> Modified: lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp?rev=194290&r1=194289&r2=194290&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp (original)
> +++ lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp Fri Nov  8 17:00:26 2013
> @@ -115,6 +115,7 @@ MachOLinkingContext::MachOLinkingContext
>      : _outputFileType(MH_EXECUTE), _outputFileTypeStatic(false),
>        _doNothing(false), _arch(arch_unknown), _os(OS::macOSX), _osMinVersion(0),
>        _pageZeroSize(unspecifiedPageZeroSize),
> +      _pageSize(4096),
>        _compatibilityVersion(0), _currentVersion(0),
>        _deadStrippableDylib(false), _kindHandler(nullptr) {}
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131108/5e5282ba/attachment.html>