[llvm] r193677 - Revert "SelectionDAG: Teach the legalizer to split SETCC if VSELECT needs splitting too."

[Juergen Ributzka]

Great! Thanks Richard.

-Juergen


On Wed, Nov 6, 2013 at 4:20 AM, Richard Sandiford <
rsandifo at linux.vnet.ibm.com> wrote:

> Richard Sandiford <rsandifo at linux.vnet.ibm.com> writes:
> > Juergen Ributzka <juergen at apple.com> writes:
> >> The problem is that getSetCCResultType() always returns a scalar value
> >> type and sign extend doesn’t like to convert from vector types to
> >> scalar types (v1i32 -> i32). I did a quick hack to
> >> getSetCCResultType() in the SystemZ backend, which seems to fix the
> >> problem. I am not familiar with the SystemZ mainframes, so I am hoping
> >> you could help me by checking and testing the following change:
> >>
> >> virtual EVT getSetCCResultType(LLVMContext &C, EVT VT) const
> LLVM_OVERRIDE {
> >>   if (VT.isVector())
> >>     return EVT::getVectorVT(C, MVT::i32, VT.getVectorNumElements());
> >>   else
> >>     return MVT::i32;
> >> }
> >
> > Sounds good to me, but it looks like other targets use:
> >
> >   if (!VT.isVector())
> >     return MVT::i32;
> >   return VT.changeVectorElementTypeToInteger();
> >
> > so maybe we should do the same here for consistency.
>
> FWIW, I just committed this as r194148.
>
> Thanks,
> Richard
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131108/a1b4eed2/attachment.html>