[PATCH] llvm-cov: Slightly improved error checking.

Yuchen Wu yuchenericwu at hotmail.com
Fri Nov 8 11:09:00 PST 2013


Thanks for the reviews, Bill!

----------------------------------------
> Subject: Re: [PATCH] llvm-cov: Slightly improved error checking.
> From: isanbard at gmail.com
> Date: Thu, 7 Nov 2013 00:23:42 -0800
> CC: llvm-commits at cs.uiuc.edu
> To: yuchenericwu at hotmail.com
>
> LGTM.
>
> -bw
>
> On Nov 6, 2013, at 3:31 PM, Yuchen Wu <yuchenericwu at hotmail.com> wrote:
>
>> llvm-cov: Slightly improved error checking.
>>
>> - readInt() should check all 4 bytes can be read, not just 1.
>> - In the event of false data in the gcno file, it was possible to index
>> into a non-existent index of SmallVector, causing assertion error. <0019-llvm-cov-Slightly-improved-error-checking.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 		 	   		  



More information about the llvm-commits mailing list