[PATCH] Share some stack walking code between Windows and Linux

Alexey Samsonov samsonov at google.com
Fri Nov 8 09:54:44 PST 2013


  Looks good.


================
Comment at: lib/sanitizer_common/sanitizer_win.cc:385
@@ +384,3 @@
+                               (void**)trace, 0);
+  uptr pc_location = LocatePcInTrace(pc);
+  PopStackFrames(pc_location);
----------------
Can you specify pc_threshold and max_pc_depth here, instead of using default arg values? I also wonder if 64 for pc_threshold will also solve the problem with malloc/free stacks indicated by FIXME.


http://llvm-reviews.chandlerc.com/D2126



More information about the llvm-commits mailing list