[PATCH] Lit to use the same rules for XFAIL and REQUIRES, to allow target-architecture-specific tests

[Artyom Skrobov]

Hello,

At present, the REQUIRES: clause matches only config.available_features, but
XFAIL: also matches target triple substrings. This makes it easy to XFAIL a
test on a certain platform; but there's no easy way to do the opposite and
mark a test as only expected to pass on a certain platform -- short of
specifying all other known platforms on the XFAIL line.

Our proposed patch makes both clauses share the same rules, both for
consistency in Lit behaviour, and for ease of setting up
target-architecture-specific tests.

For example, the XFAIL lines in test/ExecutionEngine/MCJIT/ (see
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130930/190084.
html) make it very non-obvious which platform(s), if any, the tests should
*not* fail on. With the proposed change to Lit, the applicability of those
tests could be made clearer.

Also for review, although not directly related, is an update to
formats/googletest.py, to make it return the test results as lit.Test.Result
objects, instead of (code, output) tuples: according to a comment in
run.py:168, such tuples are a deprecated way of returning the tests results.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Lit.patch
Type: application/octet-stream
Size: 3315 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131108/269b711b/attachment.obj>