[PATCH] Avoid illegal integer promotion in X86FastISel

Eric Christopher echristo at gmail.com
Thu Nov 7 15:11:17 PST 2013


Good catch, yes, please do.

-eric


On Thu, Nov 7, 2013 at 2:43 PM, Michael Liao <michael.liao at intel.com> wrote:

> Could you pipe the output directly into FileCheck instead of generating
> a temporary file? Sometimes, garbage file left may pass a test
> unintentionally.
>
> - michael
>
> On Wed, 2013-11-06 at 16:23 -0800, Duncan P. N. Exon Smith wrote:
> > This patch changes fastisel to only fold constant add operations into
> > GEPs when the type sizes match.  Without it, the operands of the add
> > are implicitly promoted, changing the conditions of an overflow and
> > the result of the GEP.
> >
> > <rdar://problem/15292280>
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131107/ce8549e6/attachment.html>


More information about the llvm-commits mailing list