[PATCH] Avoid illegal integer promotion in X86FastISel

Eric Christopher echristo at gmail.com
Thu Nov 7 14:21:29 PST 2013


Seems reasonable, pretty sure the ARM port has the same bug though so could
you fix it in both places? Maybe pull it out into more general code
somewhere?

-eric


On Wed, Nov 6, 2013 at 4:23 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> This patch changes fastisel to only fold constant add operations into GEPs
> when the type sizes match.  Without it, the operands of the add are
> implicitly promoted, changing the conditions of an overflow and the result
> of the GEP.
>
> <rdar://problem/15292280>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131107/941e521b/attachment.html>


More information about the llvm-commits mailing list