[PATCH] llvm-cov: Replaced asserts with proper error handling

Yuchen Wu yuchenericwu at hotmail.com
Wed Nov 6 14:20:42 PST 2013


Somehow in modifying previous patch the adding of the test_fail.gcda got lost.

Anyway it's back now, but I decided to test test_read_fail.gcno for failure now (foreshadowing a future patch).

----------------------------------------
> Date: Fri, 1 Nov 2013 16:58:24 -0400
> Subject: Re: [PATCH] llvm-cov: Replaced asserts with proper error handling
> From: rafael.espindola at gmail.com
> To: yuchenericwu at hotmail.com
> CC: llvm-commits at cs.uiuc.edu; jbogner at apple.com
>
> On 31 October 2013 19:08, Yuchen Wu <yuchenericwu at hotmail.com> wrote:
>> Rafael: Is this along the lines of what you were looking for?
>
> Yes. The 'not' utility differentiates crashes and regular errors, so
> that is perfect.
>
> (I don't know llvm-cov to review the patch proper, but I am happy with
> the tests).
>
> Cheers,
> Rafael 		 	   		  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-llvm-cov-Replaced-asserts-with-proper-error-handling.patch
Type: application/octet-stream
Size: 9925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131106/f24f2fee/attachment.obj>


More information about the llvm-commits mailing list