[PATCH] llvm-cov: Removed StripMap holding GCOVLines

Justin Bogner mail at justinbogner.com
Wed Nov 6 10:32:49 PST 2013


LGTM, but the error message of "unexpected source file" isn't very clear.
Maybe something more along the lines of "multiple sources for a single
basic block" would be more precise?

On Tuesday, November 5, 2013, Yuchen Wu wrote:

> llvm-cov: Removed StringMap holding GCOVLines.
>
> According to the hazy gcov documentation, it appeared to be technically
> possible for lines within a block to belong to different source files.
> However, upon further investigation, gcov does not actually support
> multiple source files for a single block.
>
> This change removes a level of separation between blocks and lines by
> replacing the StringMap of GCOVLines with a SmallVector of ints
> representing line numbers. This also means that the GCOVLines class is
> no longer needed.
>
> This paves the way for supporting the "-a" option, which will output
> block information.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131106/06315e57/attachment.html>


More information about the llvm-commits mailing list