[PATCH] Add a DecomposeVectors pass
hfinkel at anl.gov
hfinkel at anl.gov
Wed Nov 6 09:13:55 PST 2013
Does this handle vector GEPs? %A = getelementptr <4 x i8*> %ptrs, <4 x i64> %offsets,
================
Comment at: lib/Transforms/Scalar/DecomposeVectors.cpp:286
@@ +285,3 @@
+// llvm.mem.parallel_loop_access.
+void DecomposeVectors::transferMetadata(Instruction *Op,
+ const ValueVector &CV) {
----------------
Pekka Jääskeläinen wrote:
> I'm not sure if it's safe to blindly transfer all metadata. Isn't it against the MD principles: if a pass doesn't understand the metadata's purpose, it should drop it, and it should be the safe thing to do. I do not have an example in mind, but it might be safer to white list the known OK MD (which you already list in the function comment)?
I'd like to second this. Only metadata that is currently understood can be transferred.
http://llvm-reviews.chandlerc.com/D2112
More information about the llvm-commits
mailing list