Cool! LGTM except if we want the attribute for abs atom as well. ================ Comment at: include/lld/Core/DefinedAtom.h:195 @@ -188,1 +194,3 @@ + }; + struct Alignment { ---------------- We need this attribute even for absolute atoms too. http://llvm-reviews.chandlerc.com/D1799