[PATCH] [ASan] Add CMake configs for libclang_rt.asan_iossim_dynamic.dylib

[Alexander Potapenko]

================
Comment at: ../projects/compiler-rt/CMakeLists.txt:208
@@ -189,4 +207,3 @@
   endif()
-  list(APPEND SANITIZER_COMMON_CFLAGS
-    -mmacosx-version-min=${SANITIZER_MIN_OSX_VERSION})
+  set(OSX_CFLAGS -mmacosx-version-min=${SANITIZER_MIN_OSX_VERSION})
 endif()
----------------
Alexey Samsonov wrote:
> Consider having DARWIN_osx_CFLAGS and DARWIN_iossim_CFLAGS...
Good idea indeed.

================
Comment at: ../projects/compiler-rt/CMakeLists.txt:209
@@ -192,2 +208,3 @@
+  set(OSX_CFLAGS -mmacosx-version-min=${SANITIZER_MIN_OSX_VERSION})
 endif()
 
----------------
Alexey Samsonov wrote:
> IOSSIM_CFLAGS should be defined here as well for consistency.
Done.

================
Comment at: ../projects/compiler-rt/CMakeLists.txt:47
@@ +46,3 @@
+
+set(SANITIZER_COMMON_SUPPORTED_DARWIN_OS osx)
+if (IOSSIM_SDK_DIR)
----------------
Alexey Samsonov wrote:
> Please move this below, closer to SANITIZER_COMMON_SUPPORTED_ARCH, and maybe even put this under "if(APPLE)" block.
Done.

================
Comment at: ../projects/compiler-rt/CMakeLists.txt:34
@@ -33,1 +33,3 @@
 
+# Obtain the iOS Simulator SDK path from xcodebuild.
+if(APPLE)
----------------
Alexey Samsonov wrote:
> Please put this block below, closer to the place where you actually use it.
This var is used in AddCompilerRT, so I can't move it below.


http://llvm-reviews.chandlerc.com/D2080