[llvm] r194034 - llvm-cov: Added command-line option to change dir.

[Alp Toker]

On 05/11/2013 01:38, Alp Toker wrote:
> Hello Yuchen,
>
> Other code in LLVM doesn't include unistd.h without a platform ifdef,
> could this be a portability problem?

In fact, please try to avoid doing chdir() within program code -- this
is unprecedented in the LLVM utilities.

Regardless of portability, changing directory in a tool is unexpected
and difficult to model externally.

Couldn't you chdir in the lit test itself if really necessary?

Please revert.

Alp.

>
> Alp.
>
> On 05/11/2013 01:20, Yuchen Wu wrote:
>> Modified: llvm/trunk/tools/llvm-cov/llvm-cov.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/llvm-cov.cpp?rev=194034&r1=194033&r2=194034&view=diff
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-cov/llvm-cov.cpp (original)
>> +++ llvm/trunk/tools/llvm-cov/llvm-cov.cpp Mon Nov  4 19:20:41 2013
>> @@ -20,6 +20,7 @@
>>  #include "llvm/Support/raw_ostream.h"
>>  #include "llvm/Support/Signals.h"
>>  #include "llvm/Support/system_error.h"
>> +#include <unistd.h>
>>  using namespace llvm;
>>  

-- 
http://www.nuanti.com
the browser experts