[patch] Convert BitcodeReader to use error_code

Chris Lattner clattner at apple.com
Mon Nov 4 08:07:04 PST 2013


On Nov 1, 2013, at 1:53 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

>> Awesome!
>> 
>> I think you should make the error codes a little more coarse grained.  There isn't very much actionable based on the error codes anyway, so you can probably limit them down to 5 or 6 different codes.  Anyone trying to debug a bitcode reading problem will have to step through the code to figure out what is really wrong anyway.
> 
> The attached patch brings it down to 19. Is that OK? If not, any
> preference as to which ones should be merged?
> 

That seems fine, I agree there aren't obvious ones to merge.  LGTM!

-Chris



More information about the llvm-commits mailing list