X86TargetLowering::ExpandInlineAsm patch

Eric Christopher echristo at gmail.com
Fri Nov 1 17:16:12 PDT 2013


Nadav: Thanks, nice catches, lack of a fixed width font in gmail when this
opened makes it difficult. :)

Chris: You can use clang-format to format diffs as well.
http://clang.llvm.org/docs/ClangFormat.html

-eric


On Fri, Nov 1, 2013 at 4:25 PM, Nadav Rotem <nrotem at apple.com> wrote:

> The indentation is inconsistent (mixed tabs and spaces?) and there are
> line breaks in unexpected places (after the last return).
>
> On Nov 1, 2013, at 3:06 PM, Eric Christopher <echristo at gmail.com> wrote:
>
> Looks pretty reasonable, needs a testcase :)
>
> -eric
>
>
> On Thu, Oct 31, 2013 at 11:49 AM, Chris Smowton <chris at smowton.net> wrote:
>
>> See http://llvm.org/bugs/show_bug.**cgi?id=17757<http://llvm.org/bugs/show_bug.cgi?id=17757>for details; Chris Lattner advised I should cross-post the patch here.
>>
>> Chris
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131101/8ffbc6d8/attachment.html>


More information about the llvm-commits mailing list