[PATCH] Added TargetLowering::isVectorEltOrderLittleEndian(EVT)

Daniel Sanders Daniel.Sanders at imgtec.com
Fri Nov 1 16:36:45 PDT 2013


Yes, i agree.

I'll have to double check the big-endian MIPS MSA tests since this implies that 
they may be using the generic definition of isVectorEltOrderLittleEndian() instead
of the MIPS definition and still passing.

________________________________________
From: Quentin Colombet [qcolombet at apple.com]
Sent: 31 October 2013 20:43
To: benny.kra at gmail.com; Daniel Sanders
Cc: llvm-commits at cs.uiuc.edu; qcolombet at apple.com
Subject: Re: [PATCH] Added TargetLowering::isVectorEltOrderLittleEndian(EVT)

================
Comment at: include/llvm/Target/TargetLowering.h:151
@@ -150,2 +150,3 @@
   bool isLittleEndian() const { return IsLittleEndian; }
+  bool isVectorEltOrderLittleEndian(EVT Ty) const { return IsLittleEndian; }
   // Return the pointer type for the given address space, defaults to
----------------
Shouldn’t this be declared as virtual?
I expect this to be called in generic code, thus we will need polymorphism here, right?


http://llvm-reviews.chandlerc.com/D1971




More information about the llvm-commits mailing list