[patch] Remove linkonce_odr_auto_hide

Chris Lattner clattner at apple.com
Fri Nov 1 09:50:06 PDT 2013


On Nov 1, 2013, at 7:55 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

> On 1 November 2013 10:34, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>>> I'm in favor of removing dead code, but please don't renumber any enums in the C API - just mark that enum value as dead.  Thanks Rafael,
>> 
>> Hi Chris. I now noticed that this has been broken before. The last
>> time in r162114. Should I try to get the enums back to their
>> pre-r162114 value or would that do more harm than good?
> 
> That change made it to 3.2 and 3.3, so it is probably better to live with it :-(

Yeah, probably better to not mess with it.

> 
> Let me know if the attached patch is OK.

LGTM!

-Chris



More information about the llvm-commits mailing list