[llvm] r193861 - Fixing an order of evaluation error in an assert.

[Aaron Ballman]

Yes, I've alerted atrick, and will comment out the failing assert in
the meantime.  He can resolve whether the assert is faulty, or there's
a logic error with his patch.

~Aaron

On Fri, Nov 1, 2013 at 11:11 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> Looks like this is failing.
>
> On 1 November 2013 10:53, Aaron Ballman <aaron at aaronballman.com> wrote:
>> Author: aaronballman
>> Date: Fri Nov  1 09:53:14 2013
>> New Revision: 193861
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=193861&view=rev
>> Log:
>> Fixing an order of evaluation error in an assert.
>>
>> Modified:
>>     llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
>>
>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=193861&r1=193860&r2=193861&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Fri Nov  1 09:53:14 2013
>> @@ -6785,7 +6785,7 @@ void SelectionDAGBuilder::visitStackmap(
>>    SDNode *Call = CallEnd->getOperand(0).getNode();
>>    bool hasGlue = Call->getGluedNode();
>>
>> -  assert(Call->getNumOperands() == hasGlue ? 2 : 1 &&
>> +  assert(Call->getNumOperands() == (hasGlue ? 2 : 1) &&
>>           "Unexpected extra stackmap call arguments.");
>>
>>    // Replace the target specific call node with the stackmap intrinsic.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits