[PATCH] [ARM] Fix Tag_ABI_HardFP_use build attribute

Bradley Smith bradley.smith at arm.com
Fri Nov 1 04:27:21 PDT 2013


Ah good spot, I must have dropped that when I rebased on top of Logan's patch.

Fixed and committed as r193856, thanks.

Regards,
Bradley Smith

> -----Original Message-----
> From: Richard Barton [mailto:richard.barton at arm.com]
> Sent: 31 October 2013 12:24
> To: Bradley Smith
> Cc: llvm-commits at cs.uiuc.edu; Amara Emerson; Richard Barton
> Subject: Re: [PATCH] [ARM] Fix Tag_ABI_HardFP_use build attribute
> 
> 
>   1 test need tightening up. OK to commit with this correction.
> 
> 
> ================
> Comment at: test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll:157
> @@ +156,3 @@
> +; CORTEX-M4-SOFT:  .eabi_attribute 9, 2
> +; CORTEX-M4-SOFT:  .fpu vfpv4
> +; CORTEX-M4-SOFT:  .eabi_attribute 20, 1
> ----------------
> M4 is d16 only -so this line should be .fpu vfpv4-d16 as before.
> 
> TRM ref:
> http://infocenter.arm.com/help/topic/com.arm.doc.ddi0439d/BEHDEEJE.html
> 
> ================
> Comment at: test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll:172
> @@ +171,3 @@
> +; CORTEX-M4-HARD:  .eabi_attribute 9, 2
> +; CORTEX-M4-HARD:  .fpu vfpv4
> +; CORTEX-M4-HARD:  .eabi_attribute 20, 1
> ----------------
> Same comment as above.
> 
> 
> http://llvm-reviews.chandlerc.com/D2064







More information about the llvm-commits mailing list