[PATCH] Consider error-reporting calls cold in BPI

[Chandler Carruth]

On Thu, Oct 31, 2013 at 7:29 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> ----- Original Message -----
> > ----- Original Message -----
> > >
> > > Actually looking at this patch, why not do this in the pass which
> > > adds function attributes by adding the cold attribute to error
> > > reporting library functions?
>
> Unless we're willing to mark all calls to fprintf as cold (which I don't
> think that we want to do), then I can't add the attributes to the function
> declarations. Only noreturn, nounwind, readonly and readnone are currently
> supported as call-site function attributes. Being able to mark particular
> call sites as cold does seem to make sense, so maybe this is worth
> extending?
>

That had been my thought.


>
> You're specifically referring to IPO/FunctionAttrs.cpp?
>

Yep.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131031/f12a9a78/attachment.html>