[PATCH] OCaml bindings: rewrite unit tests for Llvm_target

[Peter Zotov]

Hi sylvestre.ledru,

Make tests actually check the returned values

http://llvm-reviews.chandlerc.com/D2085

Files:
  test/Bindings/Ocaml/target.ml

Index: test/Bindings/Ocaml/target.ml
===================================================================
--- test/Bindings/Ocaml/target.ml
+++ test/Bindings/Ocaml/target.ml
@@ -1,7 +1,7 @@
 (* RUN: rm -rf %t.builddir
  * RUN: mkdir -p %t.builddir
  * RUN: cp %s %t.builddir
- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_target.cmxa %t.builddir/target.ml -o %t
+ * RUN: %ocamlopt -g -warn-error A llvm.cmxa llvm_target.cmxa %t.builddir/target.ml -o %t
  * RUN: %t %t.bc
  * XFAIL: vg_leak
  *)
@@ -21,10 +21,11 @@
 (* Tiny unit test framework - really just to help find which line is busted *)
 let print_checkpoints = false
 
-let suite name f =
-  if print_checkpoints then
-    prerr_endline (name ^ ":");
-  f ()
+let _ =
+  Printexc.record_backtrace true
+
+let assert_equal a b =
+  if a <> b then failwith "assert_equal"
 
 
 (*===-- Fixture -----------------------------------------------------------===*)
@@ -36,27 +37,29 @@
 (*===-- Target Data -------------------------------------------------------===*)
 
 let test_target_data () =
-  let td = DataLayout.create (target_triple m) in
-  let sty = struct_type context [| i32_type; i64_type |] in
-  
-  ignore (DataLayout.as_string td);
-  ignore (byte_order td);
-  ignore (pointer_size td);
-  ignore (intptr_type td);
-  ignore (size_in_bits td sty);
-  ignore (store_size td sty);
-  ignore (abi_size td sty);
-  ignore (stack_align td sty);
-  ignore (preferred_align td sty);
-  ignore (preferred_align_of_global td (declare_global sty "g" m));
-  ignore (element_at_offset td sty (Int64.of_int 1));
-  ignore (offset_of_element td sty 1);
+  let layout = "e-p:32:32:32-S32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-" ^
+               "f16:16:16-f32:32:32-f64:32:64-f128:128:128-v64:32:64-v128:32:128-" ^
+               "a0:0:64-n32" in
+  let td     = DataLayout.create layout in
+  let sty    = struct_type context [| i32_type; i64_type |] in
   
+  assert_equal (DataLayout.as_string td) layout;
+  assert_equal (byte_order td) Endian.Little;
+  assert_equal (pointer_size td) 4;
+  assert_equal (intptr_type td) i32_type;
+  assert_equal (size_in_bits td sty) (Int64.of_int 96);
+  assert_equal (store_size td sty) (Int64.of_int 12);
+  assert_equal (abi_size td sty) (Int64.of_int 12);
+  assert_equal (stack_align td sty) 4;
+  assert_equal (preferred_align td sty) 8;
+  assert_equal (preferred_align_of_global td (declare_global sty "g" m)) 8;
+  assert_equal (element_at_offset td sty (Int64.of_int 1)) 0;
+  assert_equal (offset_of_element td sty 1) (Int64.of_int 4);
   DataLayout.dispose td
 
 
 (*===-- Driver ------------------------------------------------------------===*)
 
 let _ =
-  suite "target data" test_target_data;
+  test_target_data ();
   dispose_module m
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2085.1.patch
Type: text/x-patch
Size: 2757 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131031/95450aad/attachment.bin>