[PATCH] Revert "[PECOFF] Add atoms to the PassManager file"

Shankar Kalpathi Easwaran shankarke at gmail.com
Wed Oct 30 15:36:39 PDT 2013


  This change did fix some of the failures in the test tree. Not sure why.


================
Comment at: lib/ReaderWriter/PECOFF/IdataPass.h:267
@@ -266,6 +266,3 @@
     }
-
-    auto nidatom = new (_alloc) NullImportDirectoryAtom(context);
-    context.file.addAtom(*nidatom);
-
+    new (_alloc) NullImportDirectoryAtom(context);
     connectAtoms(context);
----------------
Does the NullImportDirectoryAtom get added to the PassManager file ? If you could cleanup the change so that a code explicitly adds to the passmanager file, it would be great.



http://llvm-reviews.chandlerc.com/D2069



More information about the llvm-commits mailing list