[PATCH] Additional features for the C API
Peter Zotov
whitequark at whitequark.org
Wed Oct 30 13:00:36 PDT 2013
This should be all problems I can see.
================
Comment at: lib/Target/TargetMachineC.cpp:292
@@ +291,3 @@
+
+LLVMTripleRef LLVMCreateTripple(char* String) {
+ return wrap(new Triple(String));
----------------
Tripple, and the prototype has const char*
================
Comment at: lib/Target/TargetMachineC.cpp:288
@@ +287,3 @@
+void LLVMSetTargetMachineAsmVerbosity(LLVMTargetMachineRef Machine,
+ LLVMBool Boolean) {
+ unwrap(Machine)->setAsmVerbosityDefault(Boolean);
----------------
LLVMBool VerboseAsm ? Same for prototype.
================
Comment at: include/llvm-c/TargetMachine.h:73
@@ +72,3 @@
+/** Returns the target corresponding to the given name. */
+LLVMTargetRef LLVMGetTargetFromName(char *Name, char **ErrorMessage);
+
----------------
const char* Name? Same for implementation below.
http://llvm-reviews.chandlerc.com/D1960
More information about the llvm-commits
mailing list